> Within a feature branch, not every commit necessary passes the tests (or even builds), and that is a useful property! Here’s some ways this can be exploited:
> When fixing a bug, add a failing test first, as a separate commit. That way it becomes easy to verify for anyone that the test indeed fails without the follow up fix.
As a reviewer, I want the first commit to be passing and then the bugfix commit update the test to still pass
- Makes change of behavior obvious to reviewer
- Assumeing all commits are tested, ensures the test is testing the right thing
> When fixing a bug, add a failing test first, as a separate commit. That way it becomes easy to verify for anyone that the test indeed fails without the follow up fix.
As a reviewer, I want the first commit to be passing and then the bugfix commit update the test to still pass
- Makes change of behavior obvious to reviewer
- Assumeing all commits are tested, ensures the test is testing the right thing