On: PDF Viewing

[captainmuon]

I don't understand it... what's the benefit of this as opposed to just embedding an iframe? And whats the role of pdf.js here? They seem to just show images of the pages - non interactive and non-selectable. When you are using pdf.js, you can actually get a nice embedded viewer exactly like firefox has (and similar to chrome). And the embedded pdf.js viewer would also be more secure than the iframe, if that's your concern.

[zzleeper → captainmuon]

My guess is that it can then show deltas. I like how they show changes in graphics in e.g. PNG files

[MrBuddyCasino → captainmuon]

No its actually pdf.js rendered on a canvas [0]. But the text is non-selectable it seems?

[0] see https://github.com/papers-we-love/papers-we-love/blob/master...

[volent → MrBuddyCasino]

Wow, i don't know if it's because the pdf here is big but my computer froze when I opened this link.

[Oompa → volent]

That should definitely not happen. Does that consistently happen when you click that link?

[rcthompson → captainmuon]

Perhaps PDF.js is being used on the backend to render the images of each page.

[liviu → rcthompson]

If was so, Poppler or MuPDF were better solutions for better rendering engine and much better performances.

But Github uses client side the PDF.js, that draw the content of parsed PDF file in a canvas.