was I still using SVN, I would totally agree with you here, but git was designed to help with issues as the ones that are in the patch:
Git diff is awfully useful in displaying things like inconsistent newlines, inconsistent whitespace and it helps you keeping whitespace and code changes separate.
And then there's "git add -i" which makes it very easy to go through a file change by change and commit parts of the changes. This feels dangerous, but to keep whitespace changes separate from functional changes, it's very powerful and not dangerous at all.
Fixing a commit like this takes maybe 20 seconds more than just committing it and considering the amount of time you save when you try to fix the bug in that commit (of course there is one), it's totally worth the hassle.
Note that this relies on git features. If you don't have git, I totally agree with your point. But my comment was about a commit made with git.
To make a point: Have a look at the last change in the commit. How are these <th> tags related to the HTML5 conversion?
Now when they go back to the changes in a few weeks, wouldn't they be glad to see these changes in its own commit with its own message?
Git diff is awfully useful in displaying things like inconsistent newlines, inconsistent whitespace and it helps you keeping whitespace and code changes separate.
And then there's "git add -i" which makes it very easy to go through a file change by change and commit parts of the changes. This feels dangerous, but to keep whitespace changes separate from functional changes, it's very powerful and not dangerous at all.
Fixing a commit like this takes maybe 20 seconds more than just committing it and considering the amount of time you save when you try to fix the bug in that commit (of course there is one), it's totally worth the hassle.
Note that this relies on git features. If you don't have git, I totally agree with your point. But my comment was about a commit made with git.
To make a point: Have a look at the last change in the commit. How are these <th> tags related to the HTML5 conversion?
Now when they go back to the changes in a few weeks, wouldn't they be glad to see these changes in its own commit with its own message?