Sytse Sijbrandij from GitLab.com here. Thank you for submitting this. We hope pe...

Argorak · on March 22, 2013

Hi Sytse,

Just for future reference:

Its common courtesy to give attributions next to contributed changes in the changelog. I gladly sponsored development of one of them (API: improved return codes and docs, https://github.com/gitlabhq/gitlabhq/pull/2835) and a short nod to the involved persons would be nice.

Keep up the good work, thank you!

sytse · on March 22, 2013

Hi Arhorak,

Thank you for the reference. I think attributing the authors is a good idea. I've created https://github.com/gitlabhq/gitlabhq/pull/3303

What do you think? Is it ok to attribute to the full name?

Best regards, Sytse

Argorak · on March 22, 2013

Hi,

in the Padrino project, we usually attribute by (GH) nickname, because thats what most programmers build their identity around. Also, all involved are mentioned. In that case, it would be:

- API: improved return codes and docs. (Xylakant, justahero)

See ours:

https://github.com/padrino/padrino-framework/blob/master/CHA...

sytse · on March 22, 2013

Good points. I've added Sebastian Ziebell.

About mentioning usernames, I figured it might get a bit confusing when we get public projects on GitLab.com, you would have to guess which platform the username belongs to. What do you think?

sytse · on March 22, 2013

Thanks for understanding in https://github.com/gitlabhq/gitlabhq/pull/3303#discussion_r3...

The attribution was merged and is live on https://github.com/gitlabhq/gitlabhq/blob/master/CHANGELOG#L...

Argorak · on March 22, 2013

And thanks to you from our side :)!