Hacker News new | past | comments | ask | show | jobs | submit login

Unfortunately for compliance reasons PRs are required.

Funny part is that not even in highly regulated markets.

ISO270001 or SOC2 are pretty much something every software company will have to do.




Yes, this is why we have required PR reviews at my company. It is to meet compliance controls.

We recently talked about not requiring reviews for people in L5 and above levels but ultimately got shut down due to compliance.


SOC2 doesn't require code reviews. SOC2 is just a certification that you are following your own internal controls. There's nothing that says required PR reviews have to be one of your internal controls. That's just a common control that companies use.


I would argue that "common control that companies use" falls under "industry standard" and I would say it would make it harder to pass certification without PR reviews documented on GitHub or something alike. So it does not require but everyone expects you to do so :)


The reason that this is common is that a company hires a SOC2 consultant who tells them that PR reviews are required despite that fact that this is a complete fabrication.

Locking yourself into an enormously expensive process with no evidence of its efficacy just because you don't want read up on the process yourself or push back on a misinformed auditor is a terrible business decision.


Curious because I am not familiar: are PRs required or are PR reviews required?


Well "Peer Review" or "Code Review" is required - pull requests are easiest way to have it all documented with current state of art tooling. Otherwise you have to come up with some other way to document that for purpose of the audit.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: