Hacker News new | past | comments | ask | show | jobs | submit login

I see, I think I'm better understanding what you're getting at, and I think I agree.

> Are you annoyed that he circumvented the purpose of the code review, or that he did not act on your feedback? If the latter, I strongly urge you to change. Acting on feedback should always be optional.

This has only happened to me with a couple of individuals. Usually in these cases I'll leave a comment and it will just never be addressed; the author will request another reviewer and my comment is ignored.

I don't hold PRs hostage and if things go more than one or two rounds of back-and-forth then I'll almost always yield to the author.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: