Another one I see is the insistent nitpicker who never accepts comments on their own PRs.
FWIW:
1. Use a formatting tool and a linter in the build chain = zero formatting bullshit nitpicks.
2. Ask questions wherever possible rather than criticising. It's kinder and also less embarrassing when you thought you saw a bug and it wasn't.
3. This is the reviewer's chance to stay uptodate with the codebase.
4. This is the reviewee's chance to share blame for mistakes. Nobody who reviewed can crap on them for a bug discovered later. People who couldn't bother to review can't complain either.
5. Make positive comments whenever you can honestly do so - just reduces the stress and fosters goodwill.
6. People who behave like arseholes in PRs are usually the kind you don't want in your team. i.e. it's a way of detecting such people - see how they use a bit of power.
One thing I also like to do is send a Slack message or leave an extra comment on a PR with my overall feelings/praising anything I can.
Also, the note about the formatter/linter is gold. I'm amazed at how many teams just live with constant nitpick comments on their PRs rather than automating these checks.
FWIW:
1. Use a formatting tool and a linter in the build chain = zero formatting bullshit nitpicks.
2. Ask questions wherever possible rather than criticising. It's kinder and also less embarrassing when you thought you saw a bug and it wasn't.
3. This is the reviewer's chance to stay uptodate with the codebase.
4. This is the reviewee's chance to share blame for mistakes. Nobody who reviewed can crap on them for a bug discovered later. People who couldn't bother to review can't complain either.
5. Make positive comments whenever you can honestly do so - just reduces the stress and fosters goodwill.
6. People who behave like arseholes in PRs are usually the kind you don't want in your team. i.e. it's a way of detecting such people - see how they use a bit of power.