Hacker News new | past | comments | ask | show | jobs | submit login

I think the list os fine but if those things happen in reviews a lot, I would argue you either have a cultural problem or simply have programmers that either don't pay attention or setup guardrails for eachother, for not submitting things that would get caught up in a review like this.

Every decent IDE has an option for setting up some kind of configuration for how code should be named and structured .

I think code reviews should be somewhat pedantic, it should be done with quality in mind and with the awareness of how the future changes.

The list of patterns here are valid but if they tend to happen more than feels comfortable for the team, look at the culture of how you work.




A style-guide, linter, and formatter eliminates so many potential nits, but in my experience the teams that need them the most are often the most difficult/impossible to get any buy-in on.




Consider applying for YC's Spring batch! Applications are open till Feb 11.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: