Hacker News new | past | comments | ask | show | jobs | submit login

I hope PlusFeed's author read this:

Man that's some nasty code, horrible, don't open source that kind of "code"... it's bad, even for a 5 minute projects, it's really bad.

Open Source software is not a dumpster of your bad code.




He wrote software that many people found useful and gave it away for free. That's awfully damn generous as far as I'm concerned. You see an improvement that can be made? Then make it. But stop complaining.


On the other hand to make a huge stink about a 400 line script that is poorly designed and takes advantage of none of the APIs provided by app engine to make things preferment like back end instances or task queues is a little disingenuous.


I don't want to sound like a troll... but you're better off re-writing the whole thing... I mean look at it.

https://github.com/russellbeattie/plusfeed/blob/master/plusf...

Global variables galore, tabs no spaces, no documentation, compares to empty not just once but multiple times, pokemon style exception handling (you gotta catch them all!), 'is not None' lol, type checking instead of duck typing... Just to name a few.

14 pople forked it already, I hope those are Github bots.


You realize that you're looking at a 399 line script, right? A couple of globals are perfectly reasonable at that scale.

Also note that checking for "x is not None" is the recommended, idiomatic Python style (see http://www.python.org/dev/peps/pep-0008/ for reference).

More importantly, the script works, and was apparently used by quite a few people. Rewriting something that is already known to work, just because you don't like its style, is generally a bad idea.


This code is a complete abomination, why would you stick your neck out and defend it? What igorgue is saying is, even if somebody gave me this code, I wouldn't take it, and I concur.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: