On: We check our node_modules folder into source contr...

[emteycz]

You can have multiple commits in a PR

[lf-non → emteycz]

Yes, but a lot of people prefer to have every commit in master in a buildable state. Otherwise things like git bisect become a lot more tedious.

[xboxnolifes → lf-non]

> have every commit in master

Yes, but a PR commit is not in master.

[pjerem → xboxnolifes]

I see you, little squasher :)

[ng12 → xboxnolifes]

But then you lose the benefit. Hiding node_modules during code review is the easy part.

[clintonb → lf-non]

Some teams force all pull requests to be squashed to a single commit.