On: The most copied StackOverflow snippet of all time ...

[throwaway4good]

Honestly. The code is fine.

This is for presenting stuff in a user interface. Who cares if you can find some weird edge case using MAX_LONG and MAX_DOUBLE which never will occur in practice.

[Cthulhu_ → throwaway4good]

Until it does.

[moring → Cthulhu_]

The original doesn't have types, but the modified version of humanReadableByteCount() uses a "long bytes" and as such will fail if the file size is (Long.MAX_VALUE+1) because it cannot even accept the correct size as its argument in the first place. Implementing these edge cases makes adds one more working case to 2^63 (2^64 if negative file sizes are valid) when the bigger problem is using the type "long" when files of that size are possible on the target system.

[throwaway4good → Cthulhu_]

Readability and maintainability matters far more.

And no - the edge cannot occur as it would require a file / whatever to have that size.

[throwaway4good → throwaway4good]

For example - what is the meaning of the parameter "si"?

I betcha that is going to give you more bugs than the edge cases discussed here.

[ayewo → throwaway4good]

The parameter "si" here stands for International System of Units, or SI for short [0].

0: https://en.wikipedia.org/wiki/International_System_of_Units#...