Hacker News new | past | comments | ask | show | jobs | submit login

Where does it say in the discussion that it was accepted?

Someone suggested that it be done, and most seem to be against and no conclusion has been reached at the bottom, as far as I can tell.




AFAICT the PR author is actually the #1 developer of Mastodon and also authored the original change of renaming "posts" to "toots".


Gargron is the lead developer of Mastodon


That doesn't mean the PR is guaranteed to be merged, let alone already merged, as the submission title implies.


it doesn't, I added the comment for context in case other readers are not aware (@ "someone")


update: merged


Mastodon is open source, but Gargron 'owns' it and does most of the dev. He does what he wants, and he approves or not what other people want to do


It shows "Changes Approved" at the bottom. I've never done any collaboration work on github, does that mean it's happening?


It means that another mastodon developer (ykzts) reviewed and approved the code. However, the commits haven't been merged to the main branch yet.


no, that just means someone has given approval. The more relevant bit to "will this be merged" is that Gargron is pretty much the BDFL of Mastodon.




Join us for AI Startup School this June 16-17 in San Francisco!

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: