Hacker News new | past | comments | ask | show | jobs | submit login

I actually feel bad about pointing out issues with this code since the project is very neat. But, I'm still going to do it.

There is a problem where the code uses explicit escape sequences for colour instead of using terminfo. This is a pet peeve of mine, because it prevents things like controlling whether or not to use colour by setting TERM to the appropriate values. Or to completely disable highlighting by setting TERM to "dumb". Or even use a completely different terminal type, like if you have an old vt52 hooked up to your computer.

Terminfo is a really nice library that abstracts away all the terminal codes. It's really what should be used here.




interesting argument. will look into it




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: