Hacker News new | past | comments | ask | show | jobs | submit login

That feature breaks down in the presence of merges. But when those are not present it works OK, you see lines like this:

> force-pushed the aojea:affinity branch from 8eab3f7 to ee626e7 yesterday [0]

Where the "force pushed" links to a pretty decent UI [1], but it will include a bunch of non-import information if the person rebased and force pushed, which is a common reason for force pushing.

You can see that in this [2] long lived Kubernetes PR that was rebased, the resulting "helpful" link shows me 2094 changed files [3]. In a tool like Gerrit or Phabricator this is automatically handled and it would basically ignore this operation unless the rebase changed the code being reviewed.

0 - https://github.com/kubernetes/kubernetes/pull/88409

1 - https://github.com/kubernetes/kubernetes/compare/8eab3f73163...

2 - https://github.com/kubernetes/kubernetes/pull/85000

3 - https://github.com/kubernetes/kubernetes/compare/375873cb532...




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: