On: Tips for reviewing code you don’t like

[ravenstine]

Then we're both in agreement, because my point isn't that code shouldn't be subject to standards, but that a lot of feedback can end up being pedantic and that there needs to be a line drawn to prevent code reviews from turning into an endless cycle. If the difference is marginal, the author of the code should be able to move on to other things.

[TheHegemon → ravenstine]

The problem is that everyone seems to disagree on what pedantry is and how much marginal a difference actually is.

[brigandish → TheHegemon]

Isn't that why we have specs, tests, and (explicit) coding standards?

Once you met those then, yes, your code should go through.