Hacker News new | past | comments | ask | show | jobs | submit login

Why do you need to do that? Have you looked at the merge request approvals feature https://about.gitlab.com/2015/07/29/feature-highlight-merge-... (EE/.com only)?



It's not about the number of approvers (just one), but more the approver knowing that the submitter is done making revisions. Usually after the first merge request, we do code review then wait for revisions, that's when the tag happens.

Now this would be awesome:

> We’re thinking about more improvements to the Merge Request Approvals, the main improvement being automatic suggestions for reviewers, based on the history of the changed files in the merge request. For instance, if Jane worked a lot on a certain class and you submit a change to that class, Jane gets suggested to approve your merge request.

Today we are using the self-hosted community edition though.


To indicate that the submitter is done making revisions I advise to remove the WIP indicator http://doc.gitlab.com/ce/workflow/wip_merge_requests.html this feature is available in CE and EE.

If we start recommending automatic reviewers based on the blame this would likely be an EE feature.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: