I had extensive comments yesterday praising this (especially the low latency), & calling out the future horizons (simulcast, multi-streaming) it might lead towards.
It's still questionable to me to call this WebRTC though. My understanding is it's only output is WHIP, WebRTC-HTTP Ingestion Protocol, which is used by CDNs to actually do the WebRTC protocol browsers do. It's near WebRTC but a couple steps short, seemingly. https://www.ietf.org/archive/id/draft-ietf-wish-whip-05.txt
Copying rektide's comment here. I think it hits some really interesting points
-----
This is my vote for PR of the year in open source! Holy shit. There's amazing thing after amazing tbing listed.
> Latency. With WebRTC we are able to achieve sub second latency. With our initial measurements we see ~120 Milliseconds from Broadcaster to Playback. We believe we can continue to bring down this number as well.
More speculative, but awesome futures here that OBS will either adopt or eventually fall on the wayside to a worthy competitor on:
> Broadcast at all angles. WebRTC supports multiple video streams in the same session. OBS could experiment with broadcasting multiple scenes at once! Viewers could then switch between scenes or different views in the same game.
> Simulcast. WebRTC allows broadcasters to upload multiple streams of different quality. OBS users could upload high, med, and low streams themselves.*
Also notable Rust based, working via FFI. Is this the first Rust in OBS?
Im trying to understand a little deeper how this implementation works. There's seemingly some hardware encoding support, but as compared to using something general & flexible like gstreamer it seems a bit more hardcoded, and embedded in webrtc-rs. Not the worst I guess.
It also has this somewhat odd "whip" output, where it dumps the stream via http. Im not sure if that is the only output right now. This targets some CDN systems, which then host/peer over actual CDN. Calling this webrtc feels a little weird but ok.
Sorry I missed your comment yesterday! So many things got called out in the PR that I completely forgot about HN :/ You should re-post it in this thread! I really want people not familiar with see what is possible.
Agree on renaming from `webrtc_output` -> `whip_output`! I believe that is done in the current PR?
It's still questionable to me to call this WebRTC though. My understanding is it's only output is WHIP, WebRTC-HTTP Ingestion Protocol, which is used by CDNs to actually do the WebRTC protocol browsers do. It's near WebRTC but a couple steps short, seemingly. https://www.ietf.org/archive/id/draft-ietf-wish-whip-05.txt